kazuyukitanimura commented on code in PR #3848:
URL: https://github.com/apache/datafusion-comet/pull/3848#discussion_r3017438962
##########
native/spark-expr/src/math_funcs/ceil.rs:
##########
@@ -178,9 +177,9 @@ mod test {
unreachable!()
};
let expected = Decimal128Array::from(vec![
- Some(12400), // 124.00
- Some(12500), // 125.00
- Some(-12900), // -129.00
+ Some(124), // 124.00
+ Some(125), // 125.00
+ Some(-129), // -129.00
Review Comment:
Thanks, actually the precision and scale settings are incorrect, and forgot
to update.
So the comments are correct. Fixed the precision and scale in the tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
