andygrove commented on code in PR #3848: URL: https://github.com/apache/datafusion-comet/pull/3848#discussion_r3028473095
########## spark/src/test/resources/sql-tests/expressions/math/ceil.sql: ########## @@ -15,7 +15,6 @@ -- specific language governing permissions and limitations -- under the License. --- Config: spark.comet.expression.Ceil.allowIncompatible=true -- ConfigMatrix: parquet.enable.dictionary=false,true Review Comment: nit: It would be nice to add a decimal column to the SQL test data so that decimal ceil/floor is tested through the SQL file framework too. Something like adding a decimal(5,2) column to the test table -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
