andygrove commented on code in PR #3858:
URL: https://github.com/apache/datafusion-comet/pull/3858#discussion_r3018756366
##########
spark/src/test/scala/org/apache/comet/exec/CometNativeShuffleSuite.scala:
##########
@@ -474,4 +474,24 @@ class CometNativeShuffleSuite extends CometTestBase with
AdaptiveSparkPlanHelper
}
}
}
+
+ test("native datafusion scan - repartition count") {
+ withTempPath { dir =>
+ withSQLConf(CometConf.COMET_ENABLED.key -> "false") {
+ spark
+ .range(1000)
+ .selectExpr("id", "concat('name_', id) as name")
+ .repartition(100)
+ .write
+ .parquet(dir.toString)
+ }
+ withSQLConf(
+ CometConf.COMET_NATIVE_SCAN_IMPL.key ->
CometConf.SCAN_NATIVE_DATAFUSION,
+ CometConf.COMET_EXEC_SHUFFLE_WITH_ROUND_ROBIN_PARTITIONING_ENABLED.key
-> "true") {
Review Comment:
It looks like `native_datafusion` is used here just to easily force native
shuffle.
I am confused by the comment `For zero-column batches (e.g. COUNT queries)`
when the test isn't using a count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
