andygrove commented on code in PR #3781:
URL: https://github.com/apache/datafusion-comet/pull/3781#discussion_r3030015050
##########
dev/diffs/3.4.3.diff:
##########
@@ -2350,16 +2350,17 @@ index 351c6d698fc..583d9225cca 100644
import org.apache.spark.sql.execution.FileSourceScanExec
import org.apache.spark.sql.execution.datasources.FileFormat
import org.apache.spark.sql.execution.datasources.v2.BatchScanExec
-@@ -172,6 +174,8 @@ class ParquetRowIndexSuite extends QueryTest with
SharedSparkSession {
+@@ -172,6 +174,9 @@ class ParquetRowIndexSuite extends QueryTest with
SharedSparkSession {
private def testRowIndexGeneration(label: String, conf: RowIndexTestConf):
Unit = {
test (s"$label - ${conf.desc}") {
++ // See https://github.com/apache/datafusion-comet/issues/3432
+ // native_datafusion Parquet scan does not support row index generation.
-+ assume(CometConf.COMET_NATIVE_SCAN_IMPL.get() !=
CometConf.SCAN_NATIVE_DATAFUSION)
++ assume(!Seq(CometConf.SCAN_NATIVE_DATAFUSION,
CometConf.SCAN_AUTO).contains(CometConf.COMET_NATIVE_SCAN_IMPL.get()))
Review Comment:
Yeah, we can run these tests now ... I will push an update later today
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
