alamb opened a new issue, #11565: URL: https://github.com/apache/datafusion/issues/11565
### Is your feature request related to a problem or challenge? As of https://github.com/apache/datafusion/pull/11533 ❤️ from @connec the `CsvExec::new()` function gets marked by clippy as having too many arguments We have suppressed the clippy error for now, but that is not a good long term solution ### Describe the solution you'd like I think we should fix the clippy lint for real rather than just suppressing it ### Describe alternatives you've considered I would personally suggest a builder pattern such as the following as it is easy to document and extend in the future without breaking API changes ```rust let csv_exec = CsvExec::builder() .with_has_header(true) .with_newlines_in_values(true) ... .build()? ``` I think we could follow the model of https://docs.rs/datafusion/latest/datafusion/datasource/physical_plan/parquet/struct.ParquetExecBuilder.html ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
