alamb commented on code in PR #21236:
URL: https://github.com/apache/datafusion/pull/21236#discussion_r3035413749
##########
datafusion/common/src/dfschema.rs:
##########
@@ -117,6 +117,11 @@ pub struct DFSchema {
field_qualifiers: Vec<Option<TableReference>>,
/// Stores functional dependencies in the schema.
functional_dependencies: FunctionalDependencies,
+ /// Field names that are ambiguous in this schema because the underlying
+ /// source (e.g. a derived-table subquery) contained multiple columns with
+ /// the same unqualified name. Any attempt to reference these names
without
+ /// a qualifier should produce an [`SchemaError::AmbiguousReference`]
error.
+ ambiguous_names: HashSet<String>,
Review Comment:
DFSchema is used many places in this codebase -- I am worried that adding a
new HashSet will cause non trivial slowdown in planning. I will run some
benchmarks on this one
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
