shivbhatia10 commented on code in PR #20593:
URL: https://github.com/apache/datafusion/pull/20593#discussion_r3045195641
##########
datafusion/spark/src/function/math/ceil.rs:
##########
@@ -81,7 +81,8 @@ impl ScalarUDFImpl for SparkCeil {
}
}
dt if dt.is_integer() => Ok(dt.clone()),
Review Comment:
Yes that's my bad, I checked the Spark source code and I think they always
cast any non-decimal type to int64, I've set it up that way now:
[5ad7ef6](https://github.com/apache/datafusion/pull/20593/commits/5ad7ef6d710a57e9865415945ab4891709a64b45)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
