Xuanwo opened a new issue, #700:
URL: https://github.com/apache/datafusion-comet/issues/700

   ### What is the problem the feature request solves?
   
   ```shell
   error: the loop variable `j` is only used to index `formats`
       --> spark-expr/src/kernels/temporal.rs:1026:22
        |
   1026 |             for j in 0..formats.len() {
        |                      ^^^^^^^^^^^^^^^^
        |
        = help: for further information visit 
https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
   help: consider using an iterator
        |
   1026 |             for <item> in &formats {
        |                 ~~~~~~    ~~~~~~~~
   
   error: `assert!(false)` should probably be replaced
       --> spark-expr/src/kernels/temporal.rs:1106:13
        |
   1106 |             assert!(false)
        |             ^^^^^^^^^^^^^^
        |
        = help: use `panic!()` or `unreachable!()`
        = help: for further information visit 
https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants
   
   error: `assert!(false)` should probably be replaced
       --> spark-expr/src/kernels/temporal.rs:1119:13
        |
   1119 |             assert!(false)
        |             ^^^^^^^^^^^^^^
        |
        = help: use `panic!()` or `unreachable!()`
        = help: for further information visit 
https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants
   
   error: `assert!(false)` should probably be replaced
       --> spark-expr/src/kernels/temporal.rs:1132:13
        |
   1132 |             assert!(false)
        |             ^^^^^^^^^^^^^^
        |
        = help: use `panic!()` or `unreachable!()`
        = help: for further information visit 
https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants
   
   error: `assert!(false)` should probably be replaced
       --> spark-expr/src/kernels/temporal.rs:1145:13
        |
   1145 |             assert!(false)
        |             ^^^^^^^^^^^^^^
        |
        = help: use `panic!()` or `unreachable!()`
        = help: for further information visit 
https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants
   
   ```
   
   ### Describe the potential solution
   
   _No response_
   
   ### Additional context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to