alamb commented on code in PR #21680:
URL: https://github.com/apache/datafusion/pull/21680#discussion_r3095426005
##########
datafusion/datasource-parquet/src/opener.rs:
##########
@@ -1248,15 +1245,15 @@ impl PushDecoderStreamState {
/// fetched from the [`AsyncFileReader`] and fed back into the decoder.
/// - [`Data`](DecodeResult::Data) – a decoded batch is projected and
returned.
/// - [`Finished`](DecodeResult::Finished) – signals end-of-stream
(`None`).
- async fn transition(&mut self) -> Option<Result<RecordBatch>> {
+ ///
+ /// Takes `self` by value (rather than `&mut self`) so the generated future
Review Comment:
👍 Makes esne to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
