andygrove commented on code in PR #3982:
URL: https://github.com/apache/datafusion-comet/pull/3982#discussion_r3103609970
##########
spark/src/main/scala/org/apache/spark/sql/comet/execution/shuffle/CometShuffleExchangeExec.scala:
##########
@@ -450,12 +456,17 @@ object CometShuffleExchangeExec
false
}
+ // Preserve any prior-pass fallback decision (see `CometFallback`).
+ if (isMarkedForFallback(s)) {
+ return false
+ }
+
if (!isCometShuffleEnabledWithInfo(s)) {
return false
}
if (CometConf.COMET_DPP_FALLBACK_ENABLED.get() && stageContainsDPPScan(s))
{
- withInfo(s, "Stage contains a scan with Dynamic Partition Pruning")
+ markForFallback(s, "Stage contains a scan with Dynamic Partition
Pruning")
Review Comment:
having two approaches seems a bit hacky though. I filed follow on issue to
clean this up. https://github.com/apache/datafusion-comet/issues/3984
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
