0lai0 opened a new pull request, #3999:
URL: https://github.com/apache/datafusion-comet/pull/3999
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #3608
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
Native Parquet writes executed by Comet were updating SQL metrics
(bytes_written, rows_written) but not Spark task-level OutputMetrics. Spark UI
Stages displays the Output column from task metrics, so native write stages
could show empty output even when files were successfully written.
This change aligns native write metrics reporting with Spark UI expectations
by propagating native write totals to task-level output metrics.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
- Add reportNativeWriteOutputMetrics in CometMetricNode to bridge native
writer SQL metrics to Spark task-level OutputMetrics (bytesWritten,
recordsWritten) at task completion.
- Register this reporting hook in CometNativeWriteExec before creating
CometExecIterator, so final native metric updates are available when completion
listeners run.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Added/ran targeted ScalaTest
<img width="1280" height="309" alt="image"
src="https://github.com/user-attachments/assets/317be473-1f51-46ff-9b90-6bd944f35646";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
