andygrove opened a new pull request, #4023:
URL: https://github.com/apache/datafusion-comet/pull/4023

   ## Which issue does this PR close?
   
   N/A. Small CI chore prompted by #4021, which only added a SQL test resource 
file but still triggered the Iceberg and Spark SQL test workflows.
   
   ## Rationale for this change
   
   The Iceberg and Spark SQL test workflows run the Iceberg and Spark SQL test 
suites against Comet as a plugin. Their behavior depends on Comet plugin code 
(native, common/main, spark/main), not on Comet's own test code or standalone 
subprojects. Today these workflows run even when a PR touches only Comet's own 
tests, which wastes CI time and noise.
   
   #4021 is a concrete example: it added a single file under 
`spark/src/test/resources/sql-tests/...` and still fired both workflows.
   
   ## What changes are included in this PR?
   
   Extend `paths-ignore` on the `push` and `pull_request` triggers of 
`iceberg_spark_test.yml` and `spark_sql_test.yml` to also skip:
   
   - `spark/src/test/**` (Comet's own test code and SQL test resources)
   - `common/src/test/**` (Comet's own common-module tests)
   - `fuzz-testing/**` (standalone fuzz-testing project)
   - `spark-integration/**` (standalone integration-test project)
   - `dev/**` (dev scripts, golden-file regen)
   
   The broader `spark/src/test/**` pattern subsumes the previous 
`spark/src/test/scala/org/apache/spark/sql/benchmark/**` entry, which was 
removed.
   
   `pr_build_linux.yml` and `pr_build_macos.yml` are unchanged: they run 
Comet's own tests, so test-only changes must still trigger them. Mixed PRs (any 
src change alongside test changes) still trigger the Iceberg and Spark SQL 
workflows, because GitHub only skips when every changed file matches the ignore 
list.
   
   ## How are these changes tested?
   
   CI configuration change. The new triggers will be exercised by subsequent 
PRs. The YAML files were validated and the diff is limited to additions in 
`paths-ignore` plus the single redundant-entry removal noted above.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to