andygrove commented on PR #4019:
URL:
https://github.com/apache/datafusion-comet/pull/4019#issuecomment-4300004646
> > Is there still a functionality gap between `native_iceberg_compat` and
`native_datafusion`? I see some tests with `IgnoreCometNativeDataFusion` in the
diff files.
>
> ```
> % grep "IgnoreCometNativeDataFusion(\"" dev/diffs/3.5.8.diff
> +
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3442";))
{
> +
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3720";))
{
> +
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3720";))
{
> +
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3720";))
{
> +
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3720";))
{
> +
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3720";))
{
> +
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3720";))
{
> +
IgnoreCometNativeDataFusion("https://github.com/apache/datafusion-comet/issues/3720";))
{
> ```
>
> So #3720 and #3442. We should be able resolve #3442 now that #4011 is
merged.
#3443 is fixed in https://github.com/apache/datafusion-comet/pull/4038, so
that just leaves #3720 which is just that Comet is more lenient with type
widening and/or throws different exception than Spark. Not a correctness issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
