connec opened a new pull request, #11633: URL: https://github.com/apache/datafusion/pull/11633
## Which issue does this PR close? Closes #11565. ## Rationale for this change As part of #11533, the number of arguments required for `CsvExec::new` grew long enough (8) to trigger a clippy lint. In the interests of getting the PR merged we just suppressed the lint, with the intention of replacing it with a builder in a follow-up PR (👋). ## What changes are included in this PR? This PR introduces a `CsvExecBuilder`, along with plumbing similar to the `ParquetExecBuilder`. `CsvExec::new` has been marked as deprecated, and all usages of it in the repo have been replaced with `CsvExec::builder`. ## Are these changes tested? A document test has been added to `CsvExec` which exercises (some of) the builder public API. This is analogous to the doc test for `ParquetExec`. Additionally, `CsvExec::new` was used itself in several tests and these have all been migrated to the builder. ## Are there any user-facing changes? - Add public struct `datafusion::datasource::physical_plan::CsvExecBuilder`. - Add public method `datafusion::datasource::physical_plan::CsvExec::builder`. - Deprecate public method `datafusion::datasource::physical_plan::CsvExec::new`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
