Jefffrey commented on code in PR #20864:
URL: https://github.com/apache/datafusion/pull/20864#discussion_r3129744344
##########
datafusion/sql/src/query.rs:
##########
@@ -215,6 +215,19 @@ impl<S: ContextProvider> SqlToRel<'_, S> {
PipeOperator::Join(join) => {
self.parse_relation_join(plan, join, planner_context)
}
+ PipeOperator::Drop { columns } => {
+ let Some((first, rest)) = columns.split_first() else {
+ return plan_err!("DROP requires at least one column");
Review Comment:
I'm not familiar with the spec, just basing it off the code I see here (if
we need to ensure columns aren't empty here then it means its possible to be
empty? Or its just safety?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
