lgingerich opened a new pull request, #21819:
URL: https://github.com/apache/datafusion/pull/21819
## Which issue does this PR close?
- Closes #21818.
## Rationale for this change
Several jobs in `.github/workflows/rust.yml` rebuild dependencies cold
on every run because they don't attach `Swatinem/rust-cache`. The
workflow also maintained four separate cache keys covering roughly the
same workspace, and `taplo-cli` was still being installed from source on
every run. Part of #13813.
## What changes are included in this PR?
1. Add read-only `Swatinem/rust-cache@v2` (`shared-key: amd-ci`,
`save-if: false`) to the jobs that previously had no dep cache:
`linux-datafusion-proto-features`,
`linux-cargo-check-datafusion-functions`,
`linux-test-doc`, `linux-rustdoc`,
`verify-benchmark-results`, `sqllogictest-postgres`,
`sqllogictest-substrait`, `config-docs-check`, `vendor`.
`msrv` is intentionally excluded — `cargo msrv verify` builds
against MSRV rust versions, so the `amd-ci` cache (built with
stable) wouldn't match and would just add download overhead.
2. Consolidate `amd-ci-check`, `amd-ci-linux-test-example`, and
`amd-ci-clippy` onto the shared `amd-ci` key.
`linux-test-example` and `clippy` now use `save-if: false`;
`linux-build-lib` and `linux-test` remain the savers.
3. Replace `cargo install taplo-cli` in `cargo-toml-formatting-checks`
with `taiki-e/install-action`, matching the pattern already used
for `wasm-pack` and `cargo-msrv`.
4. Cache the deterministic `tpch-dbgen` output in
`verify-benchmark-results` keyed on the dbgen fork and scale
factor, skipping the clone + `make` + `dbgen` on cache hits.
No `needs:` graph or coverage changes.
## Are these changes tested?
Validated locally with `actionlint`; pre-existing warnings in
untouched shell blocks are unchanged. The actual cache behaviour
needs to be observed on real CI runs across multiple pushes.
## Are there any user-facing changes?
No — this is CI infrastructure only.
Made with [Cursor](https://cursor.com)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
