andygrove commented on PR #4076: URL: https://github.com/apache/datafusion-comet/pull/4076#issuecomment-4338790223
Thanks @mbutrovich. Pushed [1620e33b7](https://github.com/apache/datafusion-comet/pull/4076/commits/1620e33b7) addressing the feedback: **Performance** - Replaced the per-map `take` + final `concat` with one global `Vec<u32>` index buffer plus a single `take` over the full entries struct, mirroring `sort_batch`. - Added the three early-outs (empty input, all-null, `*is_sorted`) at the top of `spark_map_sort`. **Spark compatibility** - `MapSort` now falls back to Spark for floating-point keys when `spark.comet.exec.strictFloatingPoint=true`, matching `CometSortOrder` and `CometSortArray`. **Style** - Switched to `Arc::clone(...)` and `.expect("invariant: ...")` on the two downcasts. **Docs** - Added a MapSort section to `docs/source/user-guide/latest/compatibility/expressions/map.md` describing the Spark 4.0 behavior and the strict floating-point fallback. I'll skip microbenchmark numbers for this PR; happy to add them in a follow-up if you'd like. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
