timsaucer commented on PR #768: URL: https://github.com/apache/datafusion-python/pull/768#issuecomment-2249996193
In regards to aliases, I do think putting them on the wrappers makes sense. One thing I didn't do with #750 was to remove the alias function definitions on the rust side, even when there is an alias in the python wrapper. I'll add an issue to make sure that gets cleaned up. Yes, `count(None, distinct = True)` would be a problem. What do you think - should we update `count_star` or maybe just add to the docstring to say that `None` arguments is a special case that ignores `distinct`? In regards to `AggregateBuilder` would you be willing to wait one more release? We just merged in https://github.com/apache/datafusion/pull/11550 which I'm guessing will be in datafusion 41.0. With that we get both the aggregate functions and window functions using the same API. That might make the minimal amount of churn. But if you do want to get in the aggregates for datafusion-python 40.0 I can probably knock that out in the next couple of days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
