alamb commented on code in PR #11654: URL: https://github.com/apache/datafusion/pull/11654#discussion_r1692037984
########## datafusion/sqllogictest/test_files/parquet.slt: ########## @@ -251,25 +251,26 @@ SELECT COUNT(*) FROM timestamp_with_tz; ---- 131072 +# FIXME(#TODO) fails with feature `force_hash_collisions` Review Comment: I think the concern on https://github.com/apache/datafusion/pull/11467 was that this masks a real bug. However, what I think we should do is file a PR to investigate / restore the tests which I will do so shortly ########## datafusion/physical-plan/src/joins/hash_join.rs: ########## @@ -1985,6 +1988,8 @@ mod tests { } /// Test where the left has 2 parts, the right with 1 part => 1 part + // FIXME(#TODO) test fails with feature `force_hash_collisions` + #[cfg(not(feature = "force_hash_collisions"))] Review Comment: ```suggestion // https://github.com/apache/datafusion/issues/11658 #[cfg(not(feature = "force_hash_collisions"))] ``` ########## datafusion/sqllogictest/test_files/parquet.slt: ########## @@ -251,25 +251,26 @@ SELECT COUNT(*) FROM timestamp_with_tz; ---- 131072 +# FIXME(#TODO) fails with feature `force_hash_collisions` Review Comment: ```suggestion # FIXME(#TODO) fails with feature `force_hash_collisions` # https://github.com/apache/datafusion/issues/11660 ``` ########## datafusion/sqllogictest/test_files/sort_merge_join.slt: ########## @@ -238,16 +238,17 @@ SELECT * FROM t1 FULL JOIN t2 ON t1_id = t2_id 44 d 4 44 x 3 NULL NULL NULL 55 w 3 +# FIXME(#TODO) fails with feature `force_hash_collisions` Review Comment: ```suggestion # FIXME(#TODO) fails with feature `force_hash_collisions` # https://github.com/apache/datafusion/issues/11659 ``` ########## datafusion/physical-plan/src/joins/hash_join.rs: ########## @@ -2097,6 +2102,8 @@ mod tests { } /// Test where the left has 1 part, the right has 2 parts => 2 parts + // FIXME(#TODO) test fails with feature `force_hash_collisions` Review Comment: ```suggestion // FIXME(#TODO) test fails with feature `force_hash_collisions` // https://github.com/apache/datafusion/issues/11658 ``` ########## datafusion/physical-plan/src/joins/hash_join.rs: ########## @@ -1930,6 +1931,8 @@ mod tests { Ok(()) } + // FIXME(#TODO) test fails with feature `force_hash_collisions` + #[cfg(not(feature = "force_hash_collisions"))] Review Comment: ```suggestion // https://github.com/apache/datafusion/issues/11658 #[cfg(not(feature = "force_hash_collisions"))] ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
