andygrove commented on code in PR #1578:
URL:
https://github.com/apache/datafusion-ballista/pull/1578#discussion_r3178425178
##########
ballista/executor/src/execution_engine.rs:
##########
@@ -98,8 +115,18 @@ impl ExecutionEngine for DefaultExecutionEngine {
let plan = plan
.transform(|p| {
if let Some(reader) =
p.as_any().downcast_ref::<ShuffleReaderExec>() {
- let reader =
Arc::new(reader.change_work_dir(work_dir.to_string()));
- Ok(Transformed::yes(reader))
+ // if client_pool is not None we need to get clone of it
and
+ // invoke reader.with_client_pool_and_work_dir
Review Comment:
I do not see method `with_client_pool_and_work_dir` being called
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
