andygrove commented on code in PR #4028:
URL: https://github.com/apache/datafusion-comet/pull/4028#discussion_r3190423608
##########
spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala:
##########
@@ -1476,6 +1481,152 @@ class CometExpressionSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
testDoubleScalarExpr("expm1")
}
+ test("degrees") {
+ testDoubleScalarExpr("degrees")
+ }
+
+ test("radians") {
+ testDoubleScalarExpr("radians")
+ }
+
+ test("pi and e") {
+ withParquetTable(Seq((1, 1)), "tbl") {
+ val (_, cometPlan) =
+ checkSparkAnswerAndOperatorWithTol(sql("SELECT pi(), e() FROM tbl"))
Review Comment:
Spark will evaluate these expressions using constant folding before this
reaches Comet.
It would be better to add these tests to the Comet SQL test suite - see
contributor guide for details
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
