Samyak2 commented on code in PR #22017:
URL: https://github.com/apache/datafusion/pull/22017#discussion_r3190676073
##########
datafusion/physical-plan/src/stream.rs:
##########
@@ -338,14 +343,18 @@ impl RecordBatchReceiverStreamBuilder {
// is no place to send the error and no reason to continue.
output.send(Err(e)).await.ok();
debug!(
- "Stopping execution: error executing input: {}",
- displayable(input.as_ref()).one_line()
+ "Stopping execution: error executing input:
{input_display}",
Review Comment:
There's a return in this Err branch, so the closure ends immediately and
drops `input`, right? So in both cases, we essentially drop it after this
match. Or am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
