parthchandra opened a new pull request, #4231:
URL: https://github.com/apache/datafusion-comet/pull/4231
## Which issue does this PR close?
Closes #4155
## Rationale for this change
try_url_decode was returning incorrect results
## What changes are included in this PR?
- Add native support for `url_encode`, `url_decode`, and `try_url_decode`
(Spark 4.0+) by wiring up the existing `datafusion-spark` UDFs and handling the
`StaticInvoke` serde for `UrlCodec.encode` / `UrlCodec.decode`.
- Fix #4155: `try_url_decode` was silently dropping the
`failOnError=false` flag, causing Comet to error on malformed input where Spark
returns NULL.
## How are these changes tested?
SQL file tests -
`expressions/url/url_decode.sql` — valid inputs, malformed input errors
`expressions/url/url_encode.sql` — valid inputs, multibyte UTF-8
`expressions/url/try_url_decode.sql` — same inputs as url_decode,
malformed input returns NULL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
