adriangb commented on PR #22026: URL: https://github.com/apache/datafusion/pull/22026#issuecomment-4383485787
> Wouldn't this only prevent filter pushdown for filters that reference virtual columns? Yeah but it means we'll have to keep the split forever. Which might have been the case anyway and maybe a non issue. And that any filter that does reference virtual columns cannot be pushed down even if a part of it would benefit from doing so, e..g `row_id = 1 and pk = 1`, but I'm not sure that's a realistic scenario. In the past we prevented pushdown of projection columns and that *was* a real issue, we'd see queries in prod from users along the lines of `day = '...' OR pk = 1` that could not get pushed down. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
