pepijnve commented on issue #21231: URL: https://github.com/apache/datafusion/issues/21231#issuecomment-4395157327
> What about a visitor pattern (instead of hard coded APIs)? Maybe the existing treenode api can help That's an option, but that would then remain an external traversal that requires knowledge of all possible PhysicalExpr implementations it needs to handle. If we want to this to be independent of specific implementations we need extra methods on the trait. I'm still a bit on the fence myself if this is a sensible thing to do at this point. Today there are only `Column` and `LambdaVariable` that we would need to support. With just two implementations that are both standard types providing a new extension point may be a bit premature. I'm having a hard time coming with other examples where this might be useful. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
