andygrove opened a new pull request, #4257:
URL: https://github.com/apache/datafusion-comet/pull/4257
## Which issue does this PR close?
Refs #2232.
## Rationale for this change
Issue #2232 reported that the 0.9.1 jars were nearly twice the size of
0.9.0. Investigation showed that a stale
`org/apache/comet/darwin/aarch64/libcomet.dylib` (227MB uncompressed) was
bundled into the release jar, even though the release script had
`HAS_MACOS_SDK=false` (the default) and was not asked to ship a darwin/aarch64
binary.
Root cause: `common/pom.xml` declares two unconditional resource entries
that always bundle `libcomet.dylib` from
`native/target/{x86_64,aarch64}-apple-darwin/release` whenever those files
exist on disk. The release script runs `./mvnw clean`, but Maven only cleans
`common/target`, not Cargo's `native/target`. If the release manager has
previously run `make release-linux` (or otherwise cross-compiled to
apple-darwin) in their working tree, those stale dylibs silently leak into the
release jars produced by `build-release-comet.sh`.
## What changes are included in this PR?
- `dev/release/build-release-comet.sh`: run `cargo clean` after `mvnw clean`
so stale cross-compiled artifacts are removed before the release build.
- `docs/source/contributor-guide/release_process.md`: add a note explaining
the leakage risk and recommending release managers run from a fresh clone as a
defense-in-depth measure.
## How are these changes tested?
Manual review only. The release script is exercised by release managers
ahead of each release; no automated test exists for this code path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
