github-actions[bot] commented on PR #21071:
URL: https://github.com/apache/datafusion/pull/21071#issuecomment-4399756049

   <!-- semver-check-comment -->
   Thank you for opening this pull request!
   
   Reviewer note: 
[cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) 
reported the current version number is not SemVer-compatible with the changes 
in this pull request (compared against the base branch).
   
   <details>
   <summary>Details</summary>
   
   ```
        Cloning apache/main
       Building datafusion v53.1.0 (current)
          Built [  84.633s] (current)
        Parsing datafusion v53.1.0 (current)
         Parsed [   0.037s] (current)
       Building datafusion v53.1.0 (baseline)
          Built [  83.627s] (baseline)
        Parsing datafusion v53.1.0 (baseline)
         Parsed [   0.037s] (baseline)
       Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch)
        Checked [   0.947s] 222 checks: 222 pass, 30 skip
        Summary no semver update required
       Finished [ 171.272s] datafusion
       Building datafusion-common v53.1.0 (current)
          Built [  31.686s] (current)
        Parsing datafusion-common v53.1.0 (current)
         Parsed [   0.061s] (current)
       Building datafusion-common v53.1.0 (baseline)
          Built [  31.594s] (baseline)
        Parsing datafusion-common v53.1.0 (baseline)
         Parsed [   0.060s] (baseline)
       Checking datafusion-common v53.1.0 -> v53.1.0 (no change; assume patch)
        Checked [   0.941s] 222 checks: 222 pass, 30 skip
        Summary no semver update required
       Finished [  66.386s] datafusion-common
       Building datafusion-datasource v53.1.0 (current)
          Built [  34.907s] (current)
        Parsing datafusion-datasource v53.1.0 (current)
         Parsed [   0.031s] (current)
       Building datafusion-datasource v53.1.0 (baseline)
          Built [  34.968s] (baseline)
        Parsing datafusion-datasource v53.1.0 (baseline)
         Parsed [   0.032s] (baseline)
       Checking datafusion-datasource v53.1.0 -> v53.1.0 (no change; assume 
patch)
        Checked [   0.353s] 222 checks: 222 pass, 30 skip
        Summary no semver update required
       Finished [  71.648s] datafusion-datasource
       Building datafusion-expr v53.1.0 (current)
          Built [  24.876s] (current)
        Parsing datafusion-expr v53.1.0 (current)
         Parsed [   0.076s] (current)
       Building datafusion-expr v53.1.0 (baseline)
          Built [  24.860s] (baseline)
        Parsing datafusion-expr v53.1.0 (baseline)
         Parsed [   0.077s] (baseline)
       Checking datafusion-expr v53.1.0 -> v53.1.0 (no change; assume patch)
        Checked [   1.555s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip
   
   --- failure constructible_struct_adds_field: externally-constructible struct 
adds field ---
   
   Description:
   A pub struct constructible with a struct literal has a new pub field. 
Existing struct literals must be updated to include the new field.
           ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
          impl: 
https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron
   
   Failed in:
     field ExecutionProps.extension_types in 
/home/runner/work/datafusion/datafusion/datafusion/expr/src/execution_props.rs:78
   
        Summary semver requires new major version: 1 major and 0 minor checks 
failed
       Finished [  52.739s] datafusion-expr
       Building datafusion-ffi v53.1.0 (current)
          Built [  56.002s] (current)
        Parsing datafusion-ffi v53.1.0 (current)
         Parsed [   0.058s] (current)
       Building datafusion-ffi v53.1.0 (baseline)
          Built [  55.946s] (baseline)
        Parsing datafusion-ffi v53.1.0 (baseline)
         Parsed [   0.060s] (baseline)
       Checking datafusion-ffi v53.1.0 -> v53.1.0 (no change; assume patch)
        Checked [   0.303s] 222 checks: 222 pass, 30 skip
        Summary no semver update required
       Finished [ 113.944s] datafusion-ffi
       Building datafusion-optimizer v53.1.0 (current)
          Built [  25.273s] (current)
        Parsing datafusion-optimizer v53.1.0 (current)
         Parsed [   0.028s] (current)
       Building datafusion-optimizer v53.1.0 (baseline)
          Built [  25.489s] (baseline)
        Parsing datafusion-optimizer v53.1.0 (baseline)
         Parsed [   0.030s] (baseline)
       Checking datafusion-optimizer v53.1.0 -> v53.1.0 (no change; assume 
patch)
        Checked [   0.194s] 222 checks: 222 pass, 30 skip
        Summary no semver update required
       Finished [  52.142s] datafusion-optimizer
       Building datafusion-physical-expr v53.1.0 (current)
          Built [  23.879s] (current)
        Parsing datafusion-physical-expr v53.1.0 (current)
         Parsed [   0.044s] (current)
       Building datafusion-physical-expr v53.1.0 (baseline)
          Built [  24.146s] (baseline)
        Parsing datafusion-physical-expr v53.1.0 (baseline)
         Parsed [   0.047s] (baseline)
       Checking datafusion-physical-expr v53.1.0 -> v53.1.0 (no change; assume 
patch)
        Checked [   0.501s] 222 checks: 222 pass, 30 skip
        Summary no semver update required
       Finished [  49.693s] datafusion-physical-expr
   ```
   
   </details>
   <!-- semver-check-comment -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to