Dandandan opened a new pull request, #22086: URL: https://github.com/apache/datafusion/pull/22086
## Which issue does this PR close? - Closes #. ## Rationale for this change TPC-DS query 30 failed in the benchmark because the query referenced `c_last_review_date`, while the SF1 parquet benchmark schema exposes the customer review date key as `c_last_review_date_sk`. The existing physical planning test did not catch this because the synthetic TPC-DS schema in `test-utils` used the same non-benchmark column name as the query. ## What changes are included in this PR? This updates query 30 to use `c_last_review_date_sk` and aligns the TPC-DS planning test schema with the benchmark parquet schema. ## Are these changes tested? Yes. - `cargo test -p datafusion --test tpcds_planning q30 -- --nocapture` - `target/release/dfbench tpcds --iterations 1 --path /Users/danielheres/Code/datafusion-benchmarks/tpcds/data/sf1 --query_path datafusion/core/tests/tpc-ds --query 30` - `cargo fmt --all` - `./dev/rust_lint.sh` Note: `cargo clippy --all-targets --all-features -- -D warnings` was also attempted, but the workspace currently enables mutually exclusive `datafusion-benchmarks` allocator features (`snmalloc` and `mimalloc`) under `--all-features`, so it fails before reaching this change. The CI-style clippy command run by `./dev/rust_lint.sh` passed. ## Are there any user-facing changes? No. This fixes a benchmark query/schema mismatch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
