comphead commented on code in PR #22069:
URL: https://github.com/apache/datafusion/pull/22069#discussion_r3213769203
##########
datafusion/expr/src/utils.rs:
##########
@@ -339,7 +339,38 @@ fn get_excluded_columns(
idents.push(&excepts.first_element);
idents.extend(&excepts.additional_elements);
}
+ // Declared outside the `if let` so `idents.extend(exclude_owned.iter())`
+ // below can borrow references that outlive the inner scope.
+ #[cfg(feature = "sql")]
+ let exclude_owned: Vec<sqlparser::ast::Ident>;
if let Some(exclude) = opt_exclude {
+ #[cfg(feature = "sql")]
Review Comment:
Why can't we have unified approach, to use parser or use DataFusion, did
they diverge at some point?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
