github-actions[bot] commented on PR #22100: URL: https://github.com/apache/datafusion/pull/22100#issuecomment-4416027017
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v53.1.0 (current) Built [ 86.635s] (current) Parsing datafusion v53.1.0 (current) Parsed [ 0.038s] (current) Building datafusion v53.1.0 (baseline) Built [ 85.095s] (baseline) Parsing datafusion v53.1.0 (baseline) Parsed [ 0.038s] (baseline) Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.909s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 174.536s] datafusion Building datafusion-common v53.1.0 (current) Built [ 33.743s] (current) Parsing datafusion-common v53.1.0 (current) Parsed [ 0.062s] (current) Building datafusion-common v53.1.0 (baseline) Built [ 34.000s] (baseline) Parsing datafusion-common v53.1.0 (baseline) Parsed [ 0.065s] (baseline) Checking datafusion-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.924s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field UnnestOptions.null_handling in /home/runner/work/datafusion/datafusion/datafusion/common/src/unnest.rs:104 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/struct_pub_field_missing.ron Failed in: field preserve_nulls of struct UnnestOptions, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a365a0bdcd6b40d46b64850084613a7c5029cb42/datafusion/common/src/unnest.rs:72 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 70.075s] datafusion-common Building datafusion-physical-plan v53.1.0 (current) Built [ 31.864s] (current) Parsing datafusion-physical-plan v53.1.0 (current) Parsed [ 0.132s] (current) Building datafusion-physical-plan v53.1.0 (baseline) Built [ 31.601s] (baseline) Parsing datafusion-physical-plan v53.1.0 (baseline) Parsed [ 0.132s] (baseline) Checking datafusion-physical-plan v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.894s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 66.933s] datafusion-physical-plan Building datafusion-proto v53.1.0 (current) Built [ 53.155s] (current) Parsing datafusion-proto v53.1.0 (current) Parsed [ 0.141s] (current) Building datafusion-proto v53.1.0 (baseline) Built [ 53.358s] (baseline) Parsing datafusion-proto v53.1.0 (baseline) Parsed [ 0.144s] (baseline) Checking datafusion-proto v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 2.412s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field UnnestOptions.null_handling in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/prost.rs:534 field UnnestOptions.null_handling in /home/runner/work/datafusion/datafusion/datafusion/proto/src/generated/prost.rs:534 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/struct_pub_field_missing.ron Failed in: field preserve_nulls of struct UnnestOptions, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a365a0bdcd6b40d46b64850084613a7c5029cb42/datafusion/proto/src/generated/prost.rs:532 field preserve_nulls of struct UnnestOptions, previously in file /home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/a365a0bdcd6b40d46b64850084613a7c5029cb42/datafusion/proto/src/generated/prost.rs:532 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 112.237s] datafusion-proto Building datafusion-sql v53.1.0 (current) Built [ 38.818s] (current) Parsing datafusion-sql v53.1.0 (current) Parsed [ 0.032s] (current) Building datafusion-sql v53.1.0 (baseline) Built [ 38.648s] (baseline) Parsing datafusion-sql v53.1.0 (baseline) Parsed [ 0.033s] (baseline) Checking datafusion-sql v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.332s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 79.588s] datafusion-sql ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
