github-actions[bot] commented on PR #22106:
URL: https://github.com/apache/datafusion/pull/22106#issuecomment-4423494347

   <!-- semver-check-comment -->
   Thank you for opening this pull request!
   
   Reviewer note: 
[cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) 
reported the current version number is not SemVer-compatible with the changes 
in this pull request (compared against the base branch).
   
   <details>
   <summary>Details</summary>
   
   ```
        Cloning apache/main
       Building datafusion-expr v53.1.0 (current)
          Built [  28.848s] (current)
        Parsing datafusion-expr v53.1.0 (current)
         Parsed [   0.066s] (current)
       Building datafusion-expr v53.1.0 (baseline)
          Built [  24.749s] (baseline)
        Parsing datafusion-expr v53.1.0 (baseline)
         Parsed [   0.068s] (baseline)
       Checking datafusion-expr v53.1.0 -> v53.1.0 (no change; assume patch)
        Checked [   1.557s] 222 checks: 219 pass, 2 fail, 1 warn, 30 skip
   
   --- failure inherent_method_missing: pub method removed or renamed ---
   
   Description:
   A publicly-visible method or associated fn is no longer available under its 
prior name. It may have been renamed or removed entirely.
           ref: 
https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: 
https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/inherent_method_missing.ron
   
   Failed in:
     HigherOrderSignature::with_coerce_values_for_lambdas, previously in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/5413558180b2631b38e4baf882060ddf492fd678/datafusion/expr/src/higher_order_function.rs:130
   
   --- failure struct_pub_field_missing: pub struct's pub field removed or 
renamed ---
   
   Description:
   A publicly-visible struct has at least one public field that is no longer 
available under its prior name. It may have been renamed or removed entirely.
           ref: 
https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
          impl: 
https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/struct_pub_field_missing.ron
   
   Failed in:
     field coerce_values_for_lambdas of struct HigherOrderSignature, previously 
in file 
/home/runner/work/datafusion/datafusion/target/semver-checks/git-apache_main/5413558180b2631b38e4baf882060ddf492fd678/datafusion/expr/src/higher_order_function.rs:78
   
   --- warning partial_ord_struct_fields_reordered: struct fields reordered in 
#[derive(PartialOrd)] struct ---
   
   Description:
   A public struct that derives PartialOrd had its fields reordered. 
#[derive(PartialOrd)] uses the field order to set the struct's ordering 
behavior, so this change may break downstream code that relies on the previous 
order.
           ref: 
https://doc.rust-lang.org/std/cmp/trait.PartialOrd.html#derivable
          impl: 
https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/partial_ord_struct_fields_reordered.ron
   
   Failed in:
     HigherOrderSignature.lambda_parameters_max_iterations moved from position 
4 to 3, in 
/home/runner/work/datafusion/datafusion/datafusion/expr/src/higher_order_function.rs:80
   
        Summary semver requires new major version: 2 major and 0 minor checks 
failed
        Warning produced 1 major and 0 minor level warnings
       Finished [  56.779s] datafusion-expr
   ```
   
   </details>
   <!-- semver-check-comment -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to