gstvg commented on code in PR #22106: URL: https://github.com/apache/datafusion/pull/22106#discussion_r3240915531
########## datafusion/expr/src/type_coercion/functions.rs: ########## Review Comment: Thanks @kosiew, missed that one https://github.com/apache/datafusion/pull/22106/commits/ba110728414289a3ddf2dafac31e193e850abfb5 Just to make sure, I realized the old `value_fields_with_higher_order_udf` docs were imprecise, it should have been "Note this does not invokes `coerce_values_for_lambdas` *even* if requested by the function signature", so even with the new API, `value_fields_with_higher_order_udf` still doesn't call `coerce_values_for_lambdas` because it's used when lambdas output field aren't know yet ########## datafusion/expr/src/higher_order_function.rs: ########## Review Comment: Also at https://github.com/apache/datafusion/pull/22106/commits/ba110728414289a3ddf2dafac31e193e850abfb5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
