github-actions[bot] commented on PR #19755: URL: https://github.com/apache/datafusion/pull/19755#issuecomment-4425543985
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v53.1.0 (current) Built [ 87.453s] (current) Parsing datafusion v53.1.0 (current) Parsed [ 0.041s] (current) Building datafusion v53.1.0 (baseline) Built [ 86.141s] (baseline) Parsing datafusion v53.1.0 (baseline) Parsed [ 0.037s] (baseline) Checking datafusion v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.845s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 176.709s] datafusion Building datafusion-common v53.1.0 (current) Built [ 32.456s] (current) Parsing datafusion-common v53.1.0 (current) Parsed [ 0.061s] (current) Building datafusion-common v53.1.0 (baseline) Built [ 32.139s] (baseline) Parsing datafusion-common v53.1.0 (baseline) Parsed [ 0.060s] (baseline) Checking datafusion-common v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.994s] 222 checks: 221 pass, 1 fail, 0 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/constructible_struct_adds_field.ron Failed in: field ExecutionOptions.date_time_parser in /home/runner/work/datafusion/datafusion/datafusion/common/src/config.rs:469 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 66.936s] datafusion-common Building datafusion-functions v53.1.0 (current) Built [ 28.823s] (current) Parsing datafusion-functions v53.1.0 (current) Parsed [ 0.085s] (current) Building datafusion-functions v53.1.0 (baseline) Built [ 29.024s] (baseline) Parsing datafusion-functions v53.1.0 (baseline) Parsed [ 0.084s] (baseline) Checking datafusion-functions v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.547s] 222 checks: 220 pass, 2 fail, 0 warn, 30 skip --- failure function_parameter_count_changed: pub fn parameter count changed --- Description: A publicly-visible function now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/function_parameter_count_changed.ron Failed in: datafusion_functions::datetime::to_date now takes 1 parameters instead of 0, in /home/runner/work/datafusion/datafusion/datafusion/functions/src/datetime/mod.rs:53 --- failure type_method_marked_deprecated: type method #[deprecated] added --- Description: A type method is now #[deprecated]. Downstream crates will get a compiler warning when using this method. ref: https://doc.rust-lang.org/reference/attributes/diagnostics.html#the-deprecated-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.47.0/src/lints/type_method_marked_deprecated.ron Failed in: method datafusion_functions::datetime::to_date::ToDateFunc::new in /home/runner/work/datafusion/datafusion/datafusion/functions/src/datetime/to_date.rs:87 Summary semver requires new major version: 1 major and 1 minor checks failed Finished [ 59.970s] datafusion-functions Building datafusion-sqllogictest v53.1.0 (current) Built [ 138.104s] (current) Parsing datafusion-sqllogictest v53.1.0 (current) Parsed [ 0.024s] (current) Building datafusion-sqllogictest v53.1.0 (baseline) Built [ 136.731s] (baseline) Parsing datafusion-sqllogictest v53.1.0 (baseline) Parsed [ 0.025s] (baseline) Checking datafusion-sqllogictest v53.1.0 -> v53.1.0 (no change; assume patch) Checked [ 0.109s] 222 checks: 222 pass, 30 skip Summary no semver update required Finished [ 278.413s] datafusion-sqllogictest ``` </details> <!-- semver-check-comment --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
