mbutrovich commented on code in PR #4296:
URL: https://github.com/apache/datafusion-comet/pull/4296#discussion_r3226647664
##########
common/src/main/java/org/apache/comet/parquet/ArrowConstantColumnReader.java:
##########
@@ -80,6 +80,13 @@ public void setBatchSize(int batchSize) {
@Override
public void readBatch(int total) {
+ // Fail fast: a non-positive total here would silently yield a zero-length
Review Comment:
Code is self-documenting, we can remove these comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
