andygrove commented on PR #4229: URL: https://github.com/apache/datafusion-comet/pull/4229#issuecomment-4431344776
Thanks for the probe — that table makes the remaining surface concrete. Going with option (2): filed #4297 to track the seven unconditionally-rejected conversions, with your probe table and code copied over so the behavior is captured. Tightened the code comment and PR description here to be explicit that this PR only closes the three `schemaEvolution`-gated widenings, not the broader category. On the bigger question about deprecating `spark.comet.schemaEvolution.enabled` — filed #4298 for that investigation. It looks like the per-version defaults (`false` on 3.x, `true` on 4.x via `ShimCometConf`) already encode what Spark itself does, so if there are no remaining callers flipping it, hardcoding it into the shim seems reasonable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
