alamb commented on code in PR #21815:
URL: https://github.com/apache/datafusion/pull/21815#discussion_r3228646571
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -563,6 +569,30 @@ pub trait ExecutionPlan: Any + Debug + DisplayAs + Send +
Sync {
Ok(Arc::new(Statistics::new_unknown(&self.schema())))
}
+ /// Returns statistics for a specific partition of this `ExecutionPlan`
node.
Review Comment:
If we are going to add (yet antoher) statistics API I suggest we add one
that will be easier to extend in the future -- specifically one that can also
add new parameters without a major API change
For example, what do you think about something like
```rust
fn statistics_with_context(
&self,
args: StatisticsArgs,
_ctx: &StatisticsContext,
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
