mbutrovich commented on PR #4306: URL: https://github.com/apache/datafusion-comet/pull/4306#issuecomment-4434772364
Dropping `CometUdfBridgeSuite` from this PR. `common/` shades `org.apache.arrow.*` to `org.apache.comet.shaded.arrow.*` at the `package` phase. CI runs `./mvnw -Prelease install`, so the shaded jar is on the test classpath. The suite was compiled against unshaded Arrow, hence the `NoSuchMethodError` on `CometArrowAllocator()`. Even with that fixed, `RowCountTestUDF extends CometUDF` is compiled against unshaded `ValueVector` while the runtime interface uses the shaded one, so the override does not bind and the bridge would hit `AbstractMethodError`. The override has to be produced inside `common/` for the shade plugin to rewrite it. Workable fixes (move the suite into `common/src/test/`, or move the helper UDFs into `common/src/main/`) all add cost or ship test fixtures in the published jar. Nothing in production on this branch invokes the bridge yet, so end-to-end coverage lands with #4267 when the dispatcher drives it for real. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
