waynexia commented on code in PR #22140:
URL: https://github.com/apache/datafusion/pull/22140#discussion_r3232065863
##########
datafusion/expr/src/window_state.rs:
##########
@@ -407,34 +412,40 @@ impl WindowFrameStateRange {
})?
.descending;
- current_row_values
- .iter()
- .map(|value| {
- if value.is_null() {
- return Ok(value.clone());
+ // On overflow the boundary exceeds the type's range and is
+ // effectively unbounded within the partition. Collapse to the
+ // partition edge rather than feeding `search_in_slice` a
+ // wrapped-around target: PRECEDING searches reach `search_start`,
+ // FOLLOWING searches reach `length`.
+ let unbounded_edge = if SEARCH_SIDE { search_start } else { length
};
+ let mut targets = Vec::with_capacity(current_row_values.len());
+ for value in ¤t_row_values {
+ if value.is_null() {
+ targets.push(value.clone());
+ continue;
+ }
+ let target = if SEARCH_SIDE == is_descending {
+ match value.add_checked(delta) {
+ Ok(v) => v,
+ Err(_) => return Ok(unbounded_edge),
}
- if SEARCH_SIDE == is_descending {
- // TODO: Handle positive overflows.
Review Comment:
👍 task completed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
