martin-g opened a new pull request, #1697: URL: https://github.com/apache/datafusion-ballista/pull/1697
# Which issue does this PR close? Closes #1683. # Rationale for this change When CLI - log to stdout When TUI - log to a file The TUI app needs the whole screen. Logging to stdout breaks its UI. # What changes are included in this PR? Drop the usage of `env_logger` by the CLI app for logging to stdout. Use a dynamic logger (custom impl of MakeWriter trait) that depending on a flag logs either to stdout or a file # Are there any user-facing changes? No. In the CLI app now the user can start the TUI app without an error that the tracing logger cannot be installed because the one from env_logger is already there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
