alamb commented on code in PR #21739:
URL: https://github.com/apache/datafusion/pull/21739#discussion_r3235007740
##########
datafusion/proto/tests/cases/roundtrip_physical_plan.rs:
##########
@@ -2165,6 +2166,145 @@ async fn test_round_trip_human_display() -> Result<()> {
let sql = "select r_name, count(r_name) from region group by r_name";
roundtrip_test_sql_with_context(sql, &ctx).await?;
+ let sql = "select count(*) as count_star from region";
+ roundtrip_test_sql_with_context(sql, &ctx).await?;
+
+ Ok(())
+}
+
+#[test]
+fn test_round_trip_aliased_reverse_human_display() -> Result<()> {
Review Comment:
there is a lot of boiler plate in these tests, I wonder if there is some way
to reduce the reptition with a common fixture or something 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
