andygrove commented on code in PR #4308:
URL: https://github.com/apache/datafusion-comet/pull/4308#discussion_r3238208386
##########
spark/src/main/scala/org/apache/comet/serde/datetime.scala:
##########
@@ -364,6 +364,45 @@ object CometDateAdd extends
CometScalarFunction[DateAdd]("date_add")
object CometDateSub extends CometScalarFunction[DateSub]("date_sub")
+private object UTCTimestampSerde {
+ val tzParseIncompatReason: String =
+ "Comet's native timezone parser only accepts IANA zone IDs (e.g." +
+ " `America/Los_Angeles`) and fixed offsets in `+HH:MM` form. Spark also"
+
+ " accepts forms such as `GMT+1`, `UTC+1`, or three-letter abbreviations
like" +
+ " `PST`; queries using those forms will throw a native parse error at" +
+ " execution time."
+}
+
+object CometFromUTCTimestamp extends CometExpressionSerde[FromUTCTimestamp] {
+
+ override def getIncompatibleReasons(): Seq[String] =
Review Comment:
Yes, we do. Thanks for catching that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
