2010YOUY01 commented on code in PR #22238:
URL: https://github.com/apache/datafusion/pull/22238#discussion_r3251953346
##########
datafusion/functions-table/src/generate_series.rs:
##########
@@ -333,6 +336,29 @@ impl GenerateSeriesTable {
Ok(generator)
}
+
+ /// Detects output sort order to potentially remove `SortExec`
+ /// Now only `Int64` argument type is supported
+ fn output_ordering(&self, schema: &Schema) -> Option<PhysicalSortExpr> {
+ let step = match &self.args {
+ GenSeriesArgs::Int64Args { step, .. } => *step,
Review Comment:
I'm not sure if time type allows step like `1 year -13 month`, so I've kept
them outside the scope of this PR for simplicity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
