kosiew commented on issue #22192: URL: https://github.com/apache/datafusion/issues/22192#issuecomment-4465487730
@gstvg I agree that the latest-release check can surface semver failures that were already introduced on `main` since the last release. That is an inherent property of using the last stable release as the baseline, and it is different from the PR-local/base-branch signal. I would keep the latest-release check as the blocking signal for this issue because the requirement is to report compatibility relative to what users can install from the latest release. The base-branch check is still present as the advisory signal, so reviewers can distinguish “this PR introduced a new break vs base” from “the changed crate is already incompatible with the latest release.” I do not think we should try to diff `cargo-semver-checks` output hunks. That would be fragile because the tool output is not a stable machine-readable contract for this purpose, and it would add new filtering logic beyond the requested split. The sticky comment wording to make this limitation explicit: a latest-release failure may include pre-existing unreleased breaking changes already on `main`, and the base-branch advisory result is the signal for whether changes adds new API breakage relative to its base. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
