alamb opened a new pull request, #11722: URL: https://github.com/apache/datafusion/pull/11722
## Which issue does this PR close? N/A ## Rationale for this change As we get into serious benchmarking / optimization mode, ensuring the benchmark results are as close to what is actually run as possible is important. Thus I want to propose using `cargo release` in bench.sh even if that makes the runs take longer. Most builds of DataFusion use `cargo <cmd> --release` rather than `cargo <cmd> --profile release-nonlto` For example, I am not sure why https://github.com/apache/datafusion/pull/11718 shows improvements on some environments and not others. ## What changes are included in this PR? 1. Change `bench.sh` to use `--release` instead of `--relase-non-lto` ## Are these changes tested? I am going to run benchmarks on my test rig manually to see if this causes any differences ## Are there any user-facing changes? <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!-- If there are any breaking changes to public APIs, please add the `api change` label. --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
