jayzhan211 commented on PR #11718: URL: https://github.com/apache/datafusion/pull/11718#issuecomment-2258315701
`release mode` ```rust -------------------- Benchmark clickbench_1.json -------------------- ┏━━━━━━━━━━━━━━┳━━━━━━━━━━━━┳━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━━━━┓ ┃ Query ┃ main ┃ check-hash-first ┃ Change ┃ ┡━━━━━━━━━━━━━━╇━━━━━━━━━━━━╇━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━━━━┩ │ QQuery 0 │ 0.40ms │ 0.41ms │ no change │ │ QQuery 1 │ 38.61ms │ 37.93ms │ no change │ │ QQuery 2 │ 73.86ms │ 73.49ms │ no change │ │ QQuery 3 │ 63.24ms │ 64.05ms │ no change │ │ QQuery 4 │ 425.21ms │ 390.92ms │ +1.09x faster │ │ QQuery 5 │ 694.98ms │ 650.10ms │ +1.07x faster │ │ QQuery 6 │ 37.20ms │ 38.77ms │ no change │ │ QQuery 7 │ 38.30ms │ 37.54ms │ no change │ │ QQuery 8 │ 757.20ms │ 663.71ms │ +1.14x faster │ │ QQuery 9 │ 654.19ms │ 628.15ms │ no change │ │ QQuery 10 │ 193.07ms │ 184.71ms │ no change │ │ QQuery 11 │ 215.94ms │ 209.10ms │ no change │ │ QQuery 12 │ 728.18ms │ 689.16ms │ +1.06x faster │ │ QQuery 13 │ 1386.26ms │ 1318.11ms │ no change │ │ QQuery 14 │ 975.30ms │ 955.42ms │ no change │ │ QQuery 15 │ 487.11ms │ 472.50ms │ no change │ │ QQuery 16 │ 1799.89ms │ 1582.73ms │ +1.14x faster │ │ QQuery 17 │ 1673.83ms │ 1550.87ms │ +1.08x faster │ │ QQuery 18 │ 4557.05ms │ 3911.50ms │ +1.17x faster │ │ QQuery 19 │ 57.09ms │ 57.37ms │ no change │ │ QQuery 20 │ 1540.04ms │ 1538.60ms │ no change │ │ QQuery 21 │ 1764.33ms │ 1767.64ms │ no change │ │ QQuery 22 │ 4006.80ms │ 4007.95ms │ no change │ │ QQuery 23 │ 8261.65ms │ 7982.00ms │ no change │ │ QQuery 24 │ 492.90ms │ 474.27ms │ no change │ │ QQuery 25 │ 472.54ms │ 480.76ms │ no change │ │ QQuery 26 │ 539.63ms │ 537.50ms │ no change │ │ QQuery 27 │ 1291.92ms │ 1291.64ms │ no change │ │ QQuery 28 │ 10082.99ms │ 9922.57ms │ no change │ │ QQuery 29 │ 403.20ms │ 403.61ms │ no change │ │ QQuery 30 │ 833.31ms │ 816.01ms │ no change │ │ QQuery 31 │ 966.80ms │ 905.63ms │ +1.07x faster │ │ QQuery 32 │ 9874.88ms │ 9189.33ms │ +1.07x faster │ │ QQuery 33 │ 3504.33ms │ 3956.20ms │ 1.13x slower │ │ QQuery 34 │ 3501.75ms │ 3635.95ms │ no change │ │ QQuery 35 │ 1069.16ms │ 957.72ms │ +1.12x faster │ │ QQuery 36 │ 148.00ms │ 140.89ms │ no change │ │ QQuery 37 │ 100.97ms │ 99.02ms │ no change │ │ QQuery 38 │ 103.56ms │ 103.36ms │ no change │ │ QQuery 39 │ 378.87ms │ 373.10ms │ no change │ │ QQuery 40 │ 33.78ms │ 33.72ms │ no change │ │ QQuery 41 │ 32.01ms │ 32.04ms │ no change │ │ QQuery 42 │ 40.22ms │ 40.03ms │ no change │ └──────────────┴────────────┴──────────────────┴───────────────┘ ┏━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┳━━━━━━━━━━━━┓ ┃ Benchmark Summary ┃ ┃ ┡━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╇━━━━━━━━━━━━┩ │ Total Time (main) │ 64300.55ms │ │ Total Time (check-hash-first) │ 62206.11ms │ │ Average Time (main) │ 1495.36ms │ │ Average Time (check-hash-first) │ 1446.65ms │ │ Queries Faster │ 10 │ │ Queries Slower │ 1 │ │ Queries with No Change │ 32 │ └─────────────────────────────────┴────────────┘ ``` I guess the change is not really related to those queries, we might need specialized query that could really benefit from it. I guess the query that has high cost on arrow::Row could shows the difference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
