alamb commented on code in PR #11721:
URL: https://github.com/apache/datafusion/pull/11721#discussion_r1697215919
##########
datafusion/functions-aggregate/src/approx_percentile_cont.rs:
##########
@@ -104,6 +105,12 @@ impl ApproxPercentileCont {
None
};
+ if args.ignore_nulls {
+ return not_impl_err!(
+ "IGNORE NULLS clause not yet supported for
APPROX_PERCENTILE_CONT"
Review Comment:
Maybe we can trigger it if used as a window function `PERCENTILE_CONT(...)
OVER (PARTITION BY ... IGNORE NULLS)` 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
