parthchandra commented on PR #4350: URL: https://github.com/apache/datafusion-comet/pull/4350#issuecomment-4493255638
> LGTM. Just needs tests for invalid URLs in ANSI mode, then I think it is good to merge Added the tests but then had to `ignore` them because in Ansi mode we are incompatible (returning null instead of error). There are other incompatibilities, and I'll address them all in a follow up PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
