kumarUjjawal commented on issue #22335:
URL: https://github.com/apache/datafusion/issues/22335#issuecomment-4507319550
Claude:
`size` is already plumbed in
`datafusion/ffi/src/udaf/groups_accumulator.rs`, has been since the
original PR #14775 (Dec 2024):
- Field declaration:
[`groups_accumulator.rs:56`](https://github.com/apache/datafusion/blob/main/datafusion/ffi/src/udaf/groups_accumulator.rs#L56)
```rust
pub size: unsafe extern "C" fn(accumulator: &Self) -> usize,
- Producer wrapper: groups_accumulator.rs:170-175
(https://github.com/apache/datafusion/blob/main/datafusion/ffi/src/udaf/gro
ups_accumulator.rs#L170-L175) — size_fn_wrapper calls inner.size().
- Wired in From<Box<dyn GroupsAccumulator>>: groups_accumulator.rs:264
(https://github.com/apache/datafusion/blob/main/datafusion/ffi/src/udaf/gro
ups_accumulator.rs#L264).
- Consumer impl on ForeignGroupsAccumulator: groups_accumulator.rs:347-349
(https://github.com/apache/datafusion/blob/main/datafusion/ffi/src/udaf/gro
ups_accumulator.rs#L347-L349).
- Forced-foreign unit test asserting producer/consumer size() agreement:
groups_accumulator.rs:559-588 (https://github.com/apache/datafusion/blob/ma
in/datafusion/ffi/src/udaf/groups_accumulator.rs#L559-L588)
(test_ffi_groups_accumulator_local_bypass_inner).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
