milenkovicm commented on issue #21080: URL: https://github.com/apache/datafusion/issues/21080#issuecomment-4507405812
Just one note upgrading ballista. The Ballista implementation uses `ExecutionPlan` quite frequently and the addition of the `ExecutionPlan::apply_expressions` method has impact. Reviewing the upgrade guide/docs, it’s clear what the method does but not why it should be used. Reading the PR #20337 I see its intentionally without default implementation, so my question is what would be appropriate implementation for it? When it is safe to implement it as `Ok(TreeNodeRecursion::Continue)` and ignore call ? I believe it would make the upgrade process smoother. cc @LiaCastaneda & @alamb ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
