milenkovicm commented on code in PR #22415: URL: https://github.com/apache/datafusion/pull/22415#discussion_r3281211490
########## docs/source/library-user-guide/upgrading/54.0.0.md: ########## @@ -171,7 +171,9 @@ where string types are preferred (`UNION`, `CASE THEN/ELSE`, `NVL2`). ### `ExecutionPlan::apply_expressions` is now a required method -`apply_expressions` has been added as a **required** method on the `ExecutionPlan` trait (no default implementation). The same applies to the `FileSource` and `DataSource` traits. Any custom implementation of these traits must now implement `apply_expressions`. +`apply_expressions` is now **required** on the `ExecutionPlan`, `FileSource`, +and `DataSource` traits. It visits every `PhysicalExpr` owned by the node so +callers can analyze or rewrite them (e.g. to discover dynamic filters). Review Comment: So if I get this correctly, as we do not know which function is going to be used as a parameter, the safest approach, for implementors, is to pick one of three provided patterns, based on the number of expressions the plan has, as this function could be used to do more than one thing. Do i get this correctly ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
